Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding the "nobadge" badge to gen_example #1188

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

Iximiel
Copy link
Member

@Iximiel Iximiel commented Jan 28, 2025

Description

afterthought:
The aim of this was to cover some segmentation fault.
This does not solve those segmentation faults
But I think that that is due some problems that cam from what happen after error is used. I just solved the no badge problem in some part of the manual, but some pages like the one about the ... now it should render correcly, or at leas running an example with standalone things when you do not care about the status badge

In #1183 I randomly discovered a sigsegv when running gen_example on plumed tools.

It looked like the "nobadge" status was missing from the options when creating a badge, now it displays a in that case.

"nobadge" looks like it is the default status when gen_example is called with no arguments, so I do not know it this is the correct solution (but

Target release

I would like my code to appear in release v2.10

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

@carlocamilloni
Copy link
Member

@Iximiel lo farei su 2.10 no? a parte questo e' pronta?

@Iximiel
Copy link
Member Author

Iximiel commented Jan 29, 2025

@carlocamilloni , it slipped on master, sorry.
Originally was aimed at 2.10,

it solves the missing example in the continuation lines, but those are now rendered in an very wrong way....

@Iximiel Iximiel changed the base branch from master to v2.10 January 29, 2025 07:33
@Iximiel Iximiel marked this pull request as ready for review January 29, 2025 07:33
@Iximiel
Copy link
Member Author

Iximiel commented Jan 29, 2025

@carlocamilloni, I have no idea why (maybe I should have checked AFTER the process had finished...) but now the user-manual pages look like

@carlocamilloni carlocamilloni merged commit 4447f58 into plumed:v2.10 Jan 29, 2025
22 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants